M2: the full job lifecycle — chat, hiring, geocoding, quotes, bookings, reviews
Closes the funnel. Before this the product could match two people and then stopped: `quotes`, `bookings` and `reviews` had tables and state machines and nothing that wrote a row, the entry deck's right swipe was wired to an empty handler, and every address resolved to the city centre. Jobs tab and chat - message router: thread, send, markRead, unreadTotal. A thread is a MATCH, not a job — one job with three interested pros is three private conversations. - Current/Past segments derived from ACTIVE_JOB_STATUSES, job detail listing the pros who accepted, and the conversation itself with attachments. Hiring from the deck - A right swipe on the entry deck opened nothing. It now resolves "which job?" through a sheet — sign in, pick an open job, or post one — and calls the same deck.swipe the per-job deck does, so the open-request cap and row lock apply exactly once. Swipes are vetoable so closing the sheet returns the card. Geocoding - ST_Distance and ST_DWithin rank and filter every deck, and both operands were placeholders. Addresses now resolve through Mapbox (permanent=true, which is what licenses storing the coordinates), the server resolves points rather than trusting client-supplied lat/lng, and every stored point records how it was obtained. A `city`-precision base cannot reach the verification queue. Quote -> booking -> review - The commercial chain, minus payments. Accepting a quote is the only place a booking is created; confirming completion is what unlocks reviews and moves the pro's completed_jobs. - Reviews publish double-blind with no sweeper: each is written with published_at already set to its embargo deadline and every read filters published_at <= now(), so it publishes itself. The second review pulls both forward. A silent counterparty cannot bury a bad review by never replying. State machine changes, both deliberate - booked -> matched: a cancelled booking is not a cancelled job. - scheduled -> awaiting_confirmation: in_progress is optional, so a pro who never tapped Start can still say the work is done. Test suite - api tests ran files in parallel against one database and failed roughly one run in three on whichever file lost the race. Serialised, and three fixtures that grabbed "the first client" pinned to the seeded accounts. Also includes work from a parallel session: admin verification queue, pro public profile and reviews read path, notification sending, denormalised stats recompute, search, and observability. 318 tests passing; typecheck and lint clean across 7 packages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,119 @@
|
||||
/**
|
||||
* Which social providers get registered, and when.
|
||||
*
|
||||
* The rule that matters is "both keys or neither". With one key set,
|
||||
* better-auth still registers the provider and /sign-in/social gets as far as
|
||||
* the OAuth URL builder before throwing — a 500 on an environment that is merely
|
||||
* unconfigured. Omitting it makes the same click a clean 404 PROVIDER_NOT_FOUND,
|
||||
* which the button turns into "not set up yet" rather than "try again".
|
||||
*
|
||||
* Env is swapped per case and the module re-imported, because `lib/auth.ts`
|
||||
* reads `process.env` once at module scope — which is exactly the behaviour
|
||||
* being pinned here.
|
||||
*/
|
||||
import { config } from 'dotenv';
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest';
|
||||
|
||||
config({ path: '../../.env' });
|
||||
|
||||
const KEYS = [
|
||||
'AUTH_GOOGLE_ID',
|
||||
'AUTH_GOOGLE_SECRET',
|
||||
'AUTH_MICROSOFT_ID',
|
||||
'AUTH_MICROSOFT_SECRET',
|
||||
'AUTH_MICROSOFT_TENANT_ID',
|
||||
'AUTH_GITHUB_ID',
|
||||
'AUTH_GITHUB_SECRET',
|
||||
] as const;
|
||||
|
||||
const original = Object.fromEntries(KEYS.map((k) => [k, process.env[k]]));
|
||||
|
||||
async function providersWith(env: Partial<Record<(typeof KEYS)[number], string | undefined>>) {
|
||||
for (const key of KEYS) {
|
||||
const value = env[key];
|
||||
if (value === undefined) delete process.env[key];
|
||||
else process.env[key] = value;
|
||||
}
|
||||
|
||||
vi.resetModules();
|
||||
const { auth } = await import('@/lib/auth');
|
||||
return (auth.options.socialProviders ?? {}) as Record<string, { tenantId?: string }>;
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
for (const key of KEYS) {
|
||||
const value = original[key];
|
||||
if (value === undefined) delete process.env[key];
|
||||
else process.env[key] = value;
|
||||
}
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
describe('social provider registration', () => {
|
||||
it('registers each provider when both of its keys are present', async () => {
|
||||
const providers = await providersWith({
|
||||
AUTH_GOOGLE_ID: 'g-id',
|
||||
AUTH_GOOGLE_SECRET: 'g-secret',
|
||||
AUTH_MICROSOFT_ID: 'm-id',
|
||||
AUTH_MICROSOFT_SECRET: 'm-secret',
|
||||
AUTH_GITHUB_ID: 'gh-id',
|
||||
AUTH_GITHUB_SECRET: 'gh-secret',
|
||||
});
|
||||
|
||||
expect(Object.keys(providers).sort()).toEqual(['github', 'google', 'microsoft']);
|
||||
});
|
||||
|
||||
it('treats a half-set pair as unset rather than half-registering it', async () => {
|
||||
const providers = await providersWith({
|
||||
AUTH_GOOGLE_ID: 'g-id',
|
||||
AUTH_GOOGLE_SECRET: undefined,
|
||||
AUTH_MICROSOFT_ID: undefined,
|
||||
AUTH_MICROSOFT_SECRET: 'm-secret',
|
||||
AUTH_GITHUB_ID: 'gh-id',
|
||||
AUTH_GITHUB_SECRET: undefined,
|
||||
});
|
||||
|
||||
expect(providers.google).toBeUndefined();
|
||||
expect(providers.microsoft).toBeUndefined();
|
||||
expect(providers.github).toBeUndefined();
|
||||
});
|
||||
|
||||
it('leaves phone OTP as the only route when nothing is configured', async () => {
|
||||
const providers = await providersWith({});
|
||||
expect(Object.keys(providers)).toEqual([]);
|
||||
});
|
||||
|
||||
it('registers them independently — one missing does not take the others down', async () => {
|
||||
const providers = await providersWith({
|
||||
AUTH_GOOGLE_ID: 'g-id',
|
||||
AUTH_GOOGLE_SECRET: 'g-secret',
|
||||
});
|
||||
|
||||
expect(providers.google).toBeDefined();
|
||||
expect(providers.microsoft).toBeUndefined();
|
||||
expect(providers.github).toBeUndefined();
|
||||
});
|
||||
|
||||
it('defaults Microsoft to the multi-tenant endpoint', async () => {
|
||||
// `common` is work, school AND personal accounts. A consumer marketplace
|
||||
// that silently defaulted to a single tenant would turn away every customer
|
||||
// who is not in that organisation.
|
||||
const providers = await providersWith({
|
||||
AUTH_MICROSOFT_ID: 'm-id',
|
||||
AUTH_MICROSOFT_SECRET: 'm-secret',
|
||||
AUTH_MICROSOFT_TENANT_ID: undefined,
|
||||
});
|
||||
|
||||
expect(providers.microsoft?.tenantId).toBe('common');
|
||||
});
|
||||
|
||||
it('honours an explicit tenant so a single-organisation deploy can lock down', async () => {
|
||||
const providers = await providersWith({
|
||||
AUTH_MICROSOFT_ID: 'm-id',
|
||||
AUTH_MICROSOFT_SECRET: 'm-secret',
|
||||
AUTH_MICROSOFT_TENANT_ID: '00000000-0000-0000-0000-000000000000',
|
||||
});
|
||||
|
||||
expect(providers.microsoft?.tenantId).toBe('00000000-0000-0000-0000-000000000000');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user