M2: the full job lifecycle — chat, hiring, geocoding, quotes, bookings, reviews
Closes the funnel. Before this the product could match two people and then stopped: `quotes`, `bookings` and `reviews` had tables and state machines and nothing that wrote a row, the entry deck's right swipe was wired to an empty handler, and every address resolved to the city centre. Jobs tab and chat - message router: thread, send, markRead, unreadTotal. A thread is a MATCH, not a job — one job with three interested pros is three private conversations. - Current/Past segments derived from ACTIVE_JOB_STATUSES, job detail listing the pros who accepted, and the conversation itself with attachments. Hiring from the deck - A right swipe on the entry deck opened nothing. It now resolves "which job?" through a sheet — sign in, pick an open job, or post one — and calls the same deck.swipe the per-job deck does, so the open-request cap and row lock apply exactly once. Swipes are vetoable so closing the sheet returns the card. Geocoding - ST_Distance and ST_DWithin rank and filter every deck, and both operands were placeholders. Addresses now resolve through Mapbox (permanent=true, which is what licenses storing the coordinates), the server resolves points rather than trusting client-supplied lat/lng, and every stored point records how it was obtained. A `city`-precision base cannot reach the verification queue. Quote -> booking -> review - The commercial chain, minus payments. Accepting a quote is the only place a booking is created; confirming completion is what unlocks reviews and moves the pro's completed_jobs. - Reviews publish double-blind with no sweeper: each is written with published_at already set to its embargo deadline and every read filters published_at <= now(), so it publishes itself. The second review pulls both forward. A silent counterparty cannot bury a bad review by never replying. State machine changes, both deliberate - booked -> matched: a cancelled booking is not a cancelled job. - scheduled -> awaiting_confirmation: in_progress is optional, so a pro who never tapped Start can still say the work is done. Test suite - api tests ran files in parallel against one database and failed roughly one run in three on whichever file lost the race. Serialised, and three fixtures that grabbed "the first client" pinned to the seeded accounts. Also includes work from a parallel session: admin verification queue, pro public profile and reviews read path, notification sending, denormalised stats recompute, search, and observability. 318 tests passing; typecheck and lint clean across 7 packages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,112 @@
|
||||
/**
|
||||
* The scrubber is part of the auth boundary, not a nicety.
|
||||
*
|
||||
* On this platform a phone number is the login identity and a 6-digit OTP is
|
||||
* the credential. If either reaches Bugsink, anyone with access to the error
|
||||
* tracker can sign in as that user — so these tests assert the redaction, not
|
||||
* the happy path.
|
||||
*/
|
||||
import { describe, expect, it } from 'vitest';
|
||||
import { beforeSend, REDACTED, scrub } from '../src/lib/observability';
|
||||
|
||||
type Event = Parameters<typeof beforeSend>[0];
|
||||
|
||||
describe('scrub', () => {
|
||||
it('redacts secret-bearing keys wherever they are nested', () => {
|
||||
const out = scrub({
|
||||
safe: 'keep me',
|
||||
phoneNumber: '+34600111222',
|
||||
nested: { deeper: { token: 'abc123', otp: '445566' } },
|
||||
}) as {
|
||||
safe: string;
|
||||
phoneNumber: string;
|
||||
nested: { deeper: { token: string; otp: string } };
|
||||
};
|
||||
|
||||
expect(out.safe).toBe('keep me');
|
||||
expect(out.phoneNumber).toBe(REDACTED);
|
||||
expect(out.nested.deeper.token).toBe(REDACTED);
|
||||
expect(out.nested.deeper.otp).toBe(REDACTED);
|
||||
});
|
||||
|
||||
it('redacts a phone number found in free text, not just in a named field', () => {
|
||||
const out = scrub('failed to send to +34600111222 after 3 tries');
|
||||
expect(out).not.toContain('600111222');
|
||||
expect(out).toContain(REDACTED);
|
||||
});
|
||||
|
||||
it('redacts a bare six-digit code, which is the shape of our OTP', () => {
|
||||
expect(scrub('code 123456 expired')).toBe(`code ${REDACTED} expired`);
|
||||
});
|
||||
|
||||
it('survives a circular object rather than throwing away the report', () => {
|
||||
const a: Record<string, unknown> = { name: 'x' };
|
||||
a.self = a;
|
||||
expect(() => scrub(a)).not.toThrow();
|
||||
});
|
||||
|
||||
it('walks arrays', () => {
|
||||
const out = scrub([{ token: 'a' }, { safe: 'b' }]) as Array<Record<string, string>>;
|
||||
expect(out[0]!.token).toBe(REDACTED);
|
||||
expect(out[1]!.safe).toBe('b');
|
||||
});
|
||||
});
|
||||
|
||||
describe('beforeSend', () => {
|
||||
it('drops cookies and headers entirely', () => {
|
||||
const event = {
|
||||
request: {
|
||||
url: 'https://linkder.app/api',
|
||||
cookies: { session: 'live-credential' },
|
||||
headers: { authorization: 'Bearer live-credential' },
|
||||
},
|
||||
} as unknown as Event;
|
||||
|
||||
const out = beforeSend(event)!;
|
||||
expect(out.request?.cookies).toBeUndefined();
|
||||
expect(out.request?.headers).toBeUndefined();
|
||||
});
|
||||
|
||||
it('reduces the user to an id — never a phone or email', () => {
|
||||
const event = {
|
||||
user: { id: 'user-1', email: 'someone@example.com', phone: '+34600111222' },
|
||||
} as unknown as Event;
|
||||
|
||||
const out = beforeSend(event)!;
|
||||
expect(out.user).toEqual({ id: 'user-1' });
|
||||
});
|
||||
|
||||
it('scrubs a phone number out of the exception message', () => {
|
||||
const event = {
|
||||
exception: { values: [{ value: 'no user for +34600111222' }] },
|
||||
} as unknown as Event;
|
||||
|
||||
const out = beforeSend(event)!;
|
||||
expect(out.exception!.values![0]!.value).not.toContain('600111222');
|
||||
});
|
||||
|
||||
it('scrubs request body data and the query string', () => {
|
||||
const event = {
|
||||
request: {
|
||||
url: 'https://linkder.app/verify?code=123456',
|
||||
query_string: 'code=123456',
|
||||
data: { phoneNumber: '+34600111222', code: '123456' },
|
||||
},
|
||||
} as unknown as Event;
|
||||
|
||||
const out = beforeSend(event)!;
|
||||
expect(out.request!.query_string).not.toContain('123456');
|
||||
expect(out.request!.url).not.toContain('123456');
|
||||
expect((out.request!.data as Record<string, string>).phoneNumber).toBe(REDACTED);
|
||||
});
|
||||
|
||||
it('scrubs breadcrumbs, which is where fetch URLs accumulate', () => {
|
||||
const event = {
|
||||
breadcrumbs: [{ message: 'POST /phone-number/verify +34600111222', data: { code: '123456' } }],
|
||||
} as unknown as Event;
|
||||
|
||||
const out = beforeSend(event)!;
|
||||
expect(out.breadcrumbs![0]!.message).not.toContain('600111222');
|
||||
expect((out.breadcrumbs![0]!.data as Record<string, string>).code).toBe(REDACTED);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user